Allow setting custom user for native deployment#29
Allow setting custom user for native deployment#29beemeeupnow wants to merge 1 commit intomezo-org:mainfrom
Conversation
beemeeupnow
changed the title
tscrond
left a comment
tscrond
left a comment
There was a problem hiding this comment.
Thank you so much for contributing! Before I submit any related comments regarding this PR, it's worth clarifying that updating README/documentation is also a required part for submitting any change to the repository.
Of course Mezo team will add the appropriate CONTRIBUTING.md file to address any questions on that matter.
beemeeupnow
force-pushed
the
custom-native-user
branch
from
04935a5 to
8f32058
Compare
|
Thank you for that, it makes sense! I have now updated the native README as well. |
| @@ -4,6 +4,7 @@ | |||
| export MEZOD_CHAIN_ID="mezo_31611-1" | |||
| export MEZOD_HOME="/var/mezod" | |||
There was a problem hiding this comment.
It's worth noting that MEZOD_USER can have insufficient permissions for MEZOD_HOME. This can easily crash the installation, in order to avoid that I suggest adding a line or two about it in the docs.
There was a problem hiding this comment.
Some way of checking this in the script would also be a requirement. We have to ensure the script runs with proper parameters before even starting the installation.
There was a problem hiding this comment.
Thank you for the input. The script is still run as root and I added a function set_file_permissions() that runs before the processes are started with systemd.
Did you encounter an issue?
There was a problem hiding this comment.
Hi! Sorry for the late reply. I would kindly ask you to sync the branch with the current validator-kit to avoid any conflicts. As soon as the branch is up to date, I will review and test the PR as soon as possible.
Since my full-time responsibilities have shifted away from the Mezo project, I wasn't able to complete the request quickly. Sorry for the inconvenience, and I hope we can resolve your contribution efficiently!
| @@ -419,6 +423,7 @@ main() { | |||
| setup_systemd_skip | |||
There was a problem hiding this comment.
Setting up skip sidecar requires root permissions: https://docs.skip.build/connect/validators/quickstart#using-curl. This might be an issue too.
There was a problem hiding this comment.
The install should still be done with root/sudo, and the curl | bash is performed at that time.
beemeeupnow
force-pushed
the
custom-native-user
branch
from
8f32058 to
ce23612
Compare
2 participants
Implement custom user for native deployment. Closes #28
Edit: The v-kit.sh script should still be run with root/sudo. This change is to control the user node processes run under after installation!